From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3132 invoked by alias); 18 Sep 2002 17:38:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3000 invoked from network); 18 Sep 2002 17:38:14 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by sources.redhat.com with SMTP; 18 Sep 2002 17:38:14 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id g8IHc5X18584; Wed, 18 Sep 2002 10:38:05 -0700 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH: gdb/709, C++ static members References: <20020918154026.GA24749@nevyn.them.org> From: David Carlton Date: Wed, 18 Sep 2002 10:38:00 -0000 In-Reply-To: <20020918154026.GA24749@nevyn.them.org> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-09/txt/msg00408.txt.bz2 On Wed, 18 Sep 2002 11:40:26 -0400, Daniel Jacobowitz said: > David, your earlier patch: > * values.c (value_static_field): Treat an unresolved location the > same as a nonexistent symbol. Fix PR gdb/635. > pointed me in the right direction for this fix. As you may have > pointed out at the time, read_var_value does basically the same > thing your fix does in that case. It turns out that there's some > other cases - this particular one was LOC_CONST_BYTES - where > read_var_value does the right thing and value_static_field doesn't. > So I just had value_static_field call read_var_value, which fixes > your testcase and also a new one I'll post later for gdb/709. Interesting. I definitely want to think more about whose job it should be to handle LOC_UNRESOLVED - it seems plausible that LOC_UNRESOLVED symbols should never be allowed to escape from lookup_symbol - but now it seems that I have more location classes to consider. Hmm. David Carlton carlton@math.stanford.edu