Re: [rfa] linespec.c, part 5

[David Carlton <carlton@math.stanford.edu>]

On Sat, 16 Nov 2002 11:45:53 +0300, "Eli Zaretskii" <eliz@is.elta.co.il> said:
>> From: David Carlton <carlton@math.stanford.edu>
>> Date: 15 Nov 2002 14:25:38 -0800

>> * While preparing this patch, I noticed that the variable
>> gdb_completer_quote_characters is declared but not used; I got rid
>> of it.

> While making all these changes, you do make sure that completion on
> the names of functions, variables, classes, etc. still works, right?
> (That completion includes the correct handling of quoted names,
> btw.)

I've been running it through the testsuite, but I have no particular
reason to believe that the testsuite comprehensively tests everything
that decode_line_1 does.  There are some completion tests in
gdb.base/completion.exp, so at least some of the completion has been
tested.

It would probably be a boon to GDB for somebody to ensure that the
testsuite comprehensively tests decode_line_1.

By the way, if you were worried about the removal of
gdb_completer_quote_characters, it was replaced by an accessor
function get_gdb_completer_quote_characters a couple of years ago.

David Carlton
carlton@math.stanford.edu