From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9300 invoked by alias); 16 Nov 2002 18:53:02 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9284 invoked from network); 16 Nov 2002 18:53:01 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by sources.redhat.com with SMTP; 16 Nov 2002 18:53:01 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id gAGIqnm31317; Sat, 16 Nov 2002 10:52:49 -0800 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com, ezannoni@redhat.com Subject: Re: [rfa] linespec.c, part 5 References: <2950-Sat16Nov2002114552+0200-eliz@is.elta.co.il> From: David Carlton Date: Sat, 16 Nov 2002 10:53:00 -0000 In-Reply-To: <2950-Sat16Nov2002114552+0200-eliz@is.elta.co.il> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-11/txt/msg00441.txt.bz2 On Sat, 16 Nov 2002 11:45:53 +0300, "Eli Zaretskii" said: >> From: David Carlton >> Date: 15 Nov 2002 14:25:38 -0800 >> * While preparing this patch, I noticed that the variable >> gdb_completer_quote_characters is declared but not used; I got rid >> of it. > While making all these changes, you do make sure that completion on > the names of functions, variables, classes, etc. still works, right? > (That completion includes the correct handling of quoted names, > btw.) I've been running it through the testsuite, but I have no particular reason to believe that the testsuite comprehensively tests everything that decode_line_1 does. There are some completion tests in gdb.base/completion.exp, so at least some of the completion has been tested. It would probably be a boon to GDB for somebody to ensure that the testsuite comprehensively tests decode_line_1. By the way, if you were worried about the removal of gdb_completer_quote_characters, it was replaced by an accessor function get_gdb_completer_quote_characters a couple of years ago. David Carlton carlton@math.stanford.edu