can't build cross-gdb for --target=mips-sgi-irix6

can't build cross-gdb for --target=mips-sgi-irix6

[Alexandre Oliva]

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

mips-sgi-irix6-gdb (5.3 branch and mainline) failed to link on
athlon-pc-linux-gnu.  breakpoint.c didn't to compile in
disable_breakpoints_in_shlibs() because SOLIB_ADD was not defined.  I
think solib.h must be #included somewhere, and I think the right place
is config/mips/tm-irix6.h.  I couldn't test this natively, because I
don't have access to any irix box at the moment, but the cross
debugger built correctly with this patch.  Ok to install?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: irix-solib.patch --]
[-- Type: text/x-patch, Size: 875 bytes --]

Index: gdb/ChangeLog
from  Alexandre Oliva  <aoliva@redhat.com>

	* config/mips/tm-irix6.h: Include solib.h.

Index: gdb/config/mips/tm-irix6.h
===================================================================
RCS file: /cvs/src/src/gdb/config/mips/tm-irix6.h,v
retrieving revision 1.5
diff -u -p -r1.5 tm-irix6.h
--- gdb/config/mips/tm-irix6.h 20 Aug 2002 13:17:55 -0000 1.5
+++ gdb/config/mips/tm-irix6.h 2 Oct 2002 00:36:49 -0000
@@ -1,5 +1,5 @@
 /* Target machine description for SGI Iris under Irix 6.x, for GDB.
-   Copyright 2001
+   Copyright 2001, 2002
    Free Software Foundation, Inc.
 
    This file is part of GDB.
@@ -20,6 +20,7 @@
    Boston, MA 02111-1307, USA.  */
 
 #include "mips/tm-bigmips64.h"
+#include "solib.h"
 
 /* SGI's assembler doesn't grok dollar signs in identifiers.
    So we use dots instead.  This item must be coordinated with G++. */

[-- Attachment #3: Type: text/plain, Size: 289 bytes --]


-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                 aoliva@{redhat.com, gcc.gnu.org}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist                Professional serial bug killer

Re: can't build cross-gdb for --target=mips-sgi-irix6

[Daniel Jacobowitz]

On Tue, Oct 01, 2002 at 09:49:59PM -0300, Alexandre Oliva wrote:
> mips-sgi-irix6-gdb (5.3 branch and mainline) failed to link on
> athlon-pc-linux-gnu.  breakpoint.c didn't to compile in
> disable_breakpoints_in_shlibs() because SOLIB_ADD was not defined.  I
> think solib.h must be #included somewhere, and I think the right place
> is config/mips/tm-irix6.h.  I couldn't test this natively, because I
> don't have access to any irix box at the moment, but the cross
> debugger built correctly with this patch.  Ok to install?

Well, how does it compile when native?  It looks like nothing includes
"solib.h" in that case, so it must be getting the definitions from
somewhere...

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: can't build cross-gdb for --target=mips-sgi-irix6

[Alexandre Oliva]

On Oct  1, 2002, Daniel Jacobowitz <drow@mvista.com> wrote:

> On Tue, Oct 01, 2002 at 09:49:59PM -0300, Alexandre Oliva wrote:

>> I couldn't test this natively, because I don't have access to any
>> irix box at the moment, but the cross debugger built correctly with
>> this patch.  Ok to install?

> Well, how does it compile when native?

See above.  Testers welcome :-)

> It looks like nothing includes "solib.h" in that case, so it must be
> getting the definitions from somewhere...

I just assumed it wouldn't link either, since, as you say, solib.h
wasn't included.

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                 aoliva@{redhat.com, gcc.gnu.org}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist                Professional serial bug killer

Re: can't build cross-gdb for --target=mips-sgi-irix6

[Kevin Buettner]

On Oct 1,  9:49pm, Alexandre Oliva wrote:

> mips-sgi-irix6-gdb (5.3 branch and mainline) failed to link on
> athlon-pc-linux-gnu.  breakpoint.c didn't to compile in
> disable_breakpoints_in_shlibs() because SOLIB_ADD was not defined.  I
> think solib.h must be #included somewhere, and I think the right place
> is config/mips/tm-irix6.h.  I couldn't test this natively, because I
> don't have access to any irix box at the moment, but the cross
> debugger built correctly with this patch.  Ok to install?

Yes.

Normally, we also try to remove the #include of solib.h from the
appropriate nm-*.h files.  However, we can't easily do that for
Irix since nm-irix6.h includes nm-irix5.h which includes
config/nm-sysv4.h.  This latter file is used by a lot of other
platforms.  Once our Irix system is running again, I'll see if
I can figure out what should be done so that solib.h isn't included
more than once.  (Including it more than once is safe though because
solib.h protects itself from multiple inclusions.)

Thanks,

Kevin