From: Jim Blandy <jimb@zwingli.cygnus.com>
To: Eli Zaretskii <eliz@is.elta.co.il>
Cc: msnyder@redhat.com, gdb-patches@sources.redhat.com, ac131313@cygnus.com
Subject: Re: [RFA] enum enable
Date: Mon, 30 Jul 2001 16:24:00 -0000 [thread overview]
Message-ID: <nppuai80e4.fsf@zwingli.cygnus.com> (raw)
In-Reply-To: <200107251426.RAA18009@is.elta.co.il>
Eli Zaretskii <eliz@is.elta.co.il> writes:
>
> > From: Jim Blandy <jimb@zwingli.cygnus.com>
> > Date: 16 Jul 2001 17:04:34 -0500
> >
> > Anyway, I get compilation errors with your patch. There are uses of
> > the old struct tracepoint `enabled' member that your patch didn't
> > catch.
> >
> > (Or I botched appyling the patch.)
>
> I think one of the hunks for tracepoint.c didn't apply for you,
> because tracepoint.c has changed while I worked on this.
>
> The modified patch is attached below. With it, I patched and built
> yesterday's snapshot without any problems.
>
> Since this is just a variable-renaming patch, I hope it can be
> approved soon. Otherwise, I need a kludge in go32-nat.c to get it to
> compile, and an IDE used by DJGPP users (which links parts of GDB as
> its debugging engine) needs further kludges, due to conflicts with
> system headers. I'd hate to go into release branch with these
> kludges.
(I'm sorry I've been slow to reply. I moved last week.)
This patch still fails to build. The code your patch forgets to
change has been present in the sources for over a year. Did you do a
full rebuild?
Here are the error messages:
gcc -c -g -O2 -I. -I/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb -I/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/config -DHAVE_CONFIG_H -I/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/../include/opcode -I/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/../readline/.. -I../bfd -I/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/../bfd -I/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/../include -I../intl -I/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/../intl -DMI_OUT=1 -DUI_OUT=1 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized /home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c:115: field `status' has incomplete type
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c: In function `display_command':
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c:1436: `enabled' undeclared (first use in this function)
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c:1436: (Each undeclared identifier is reported only once
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c:1436: for each function it appears in.)
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c: In function `do_one_display':
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c:1547: `disabled' undeclared (first use in this function)
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c: In function `disable_display':
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c:1647: `disabled' undeclared (first use in this function)
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c: In function `enable_display':
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c:1703: `enabled' undeclared (first use in this function)
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c: In function `disable_display_command':
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c:1741: `disabled' undeclared (first use in this function)
make[1]: *** [printcmd.o] Error 1
make[1]: Leaving directory `/gnomon/jimb/cygnus/pentium3/sourceware/gdb/main/native/build/gdb'
make: *** [all-gdb] Error 2
Compilation exited abnormally with code 2 at Mon Jul 30 14:09:33
next prev parent reply other threads:[~2001-07-30 16:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.SUN.3.91.1010711161311.5321C-100000@is>
[not found] ` <3B4E41B5.64FB@redhat.com>
2001-07-14 4:08 ` Eli Zaretskii
2001-07-16 14:52 ` Jim Blandy
2001-07-16 15:53 ` Andrew Cagney
2001-07-17 0:06 ` Eli Zaretskii
2001-07-17 10:45 ` Jim Blandy
[not found] ` <200107180700.KAA12466@is.elta.co.il>
2001-07-18 0:34 ` Daniel Berlin
2001-07-18 10:15 ` Jim Blandy
2001-07-18 12:59 ` Eli Zaretskii
2001-07-19 5:57 ` Michael Snyder
2001-07-19 6:13 ` Eli Zaretskii
[not found] ` <npzoa4y1hp.fsf@zwingli.cygnus.com>
2001-07-17 0:07 ` Eli Zaretskii
2001-07-25 7:28 ` Eli Zaretskii
2001-07-30 16:24 ` Jim Blandy [this message]
2001-07-31 1:45 ` Eli Zaretskii
2001-07-31 16:24 ` Jim Blandy
2001-07-31 16:33 ` Jim Blandy
2001-08-01 1:53 ` Eli Zaretskii
2001-08-01 14:05 ` Andrew Cagney
2001-08-01 21:52 ` Jim Blandy
2001-08-02 5:07 ` Eli Zaretskii
2001-07-29 0:49 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nppuai80e4.fsf@zwingli.cygnus.com \
--to=jimb@zwingli.cygnus.com \
--cc=ac131313@cygnus.com \
--cc=eliz@is.elta.co.il \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox