Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@zwingli.cygnus.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: correctly detect overlapping overlays
Date: Mon, 13 Aug 2001 07:39:00 -0000	[thread overview]
Message-ID: <npofpkt44n.fsf@zwingli.cygnus.com> (raw)
In-Reply-To: <3B7737C3.8070805@cygnus.com>

Andrew Cagney <ac131313@cygnus.com> writes:
> > +   CORE_ADDR a_start = a->vma;
> > +   CORE_ADDR a_end   = a->vma + bfd_get_section_size_before_reloc (a);
> > +   CORE_ADDR b_start = b->vma;
> > +   CORE_ADDR b_end   = b->vma + bfd_get_section_size_before_reloc (b);
> 
> 
> Jim, just a reminder on coding style.
> There isn't any reason to (and probably good reason to not) lay out the 
> code so carefully.  It just makes the task of someone running indent 
> over the code all the more confusing.

I hadn't thought of people running indent.  I'll fix that.

But I do think it's a shame.  When layout can expose symmetry in what
you're doing, it makes it easier to read the code.


  reply	other threads:[~2001-08-13  7:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-12 11:42 Jim Blandy
2001-08-12 19:13 ` Andrew Cagney
2001-08-13  7:39   ` Jim Blandy [this message]
2001-08-13  9:07     ` Andrew Cagney
2001-08-13 11:25     ` Michael Snyder
2001-08-24 10:44 ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=npofpkt44n.fsf@zwingli.cygnus.com \
    --to=jimb@zwingli.cygnus.com \
    --cc=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox