Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Jim Blandy <jimb@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: correctly detect overlapping overlays
Date: Sun, 12 Aug 2001 19:13:00 -0000	[thread overview]
Message-ID: <3B7737C3.8070805@cygnus.com> (raw)
In-Reply-To: <20010812184312.C90245E9DA@zwingli.cygnus.com>

> +   CORE_ADDR a_start = a->vma;
> +   CORE_ADDR a_end   = a->vma + bfd_get_section_size_before_reloc (a);
> +   CORE_ADDR b_start = b->vma;
> +   CORE_ADDR b_end   = b->vma + bfd_get_section_size_before_reloc (b);


Jim, just a reminder on coding style.
There isn't any reason to (and probably good reason to not) lay out the 
code so carefully.  It just makes the task of someone running indent 
over the code all the more confusing.

	Andrew


  reply	other threads:[~2001-08-12 19:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-12 11:42 Jim Blandy
2001-08-12 19:13 ` Andrew Cagney [this message]
2001-08-13  7:39   ` Jim Blandy
2001-08-13  9:07     ` Andrew Cagney
2001-08-13 11:25     ` Michael Snyder
2001-08-24 10:44 ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B7737C3.8070805@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox