From: Jim Blandy <jimb@zwingli.cygnus.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: S/390: don't try to read zero bytes
Date: Thu, 20 Dec 2001 12:53:00 -0000 [thread overview]
Message-ID: <npk7vhwr11.fsf@zwingli.cygnus.com> (raw)
In-Reply-To: Andrew Cagney's message of Thu, 20 Dec 2001 11:09:59 +0000
Andrew Cagney <ac131313@cygnus.com> writes:
> > 2001-12-20 Jim Blandy <jimb@redhat.com>
> >
> > * s390-tdep.c (s390_readinstruction): Don't call
> > info->read_memory_func to read zero bytes. Some targets'
> > xfer_memory functions can't cope with that.
>
> Jim, which?
>
> While slightly stupid, the target should be able to handle that.
That was my feeling, as well. xfer_memory, in exec.c, says:
if (len <= 0)
internal_error (__FILE__, __LINE__, "failed internal consistency check");
In my opinion, the test is wrong, the error message is lousy, and it
should be an assert anyway.
next prev parent reply other threads:[~2001-12-20 20:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-20 0:56 Jim Blandy
2001-12-20 3:10 ` Andrew Cagney
2001-12-20 12:53 ` Jim Blandy [this message]
2001-12-20 12:57 ` Jim Blandy
2001-12-23 1:44 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=npk7vhwr11.fsf@zwingli.cygnus.com \
--to=jimb@zwingli.cygnus.com \
--cc=ac131313@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox