From: Andrew Cagney <ac131313@cygnus.com>
To: Jim Blandy <jimb@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: S/390: don't try to read zero bytes
Date: Sun, 23 Dec 2001 01:44:00 -0000 [thread overview]
Message-ID: <3C259803.6090007@cygnus.com> (raw)
In-Reply-To: <npitb1wquo.fsf@zwingli.cygnus.com>
> Andrew Cagney <ac131313@cygnus.com> writes:
>
>> > 2001-12-20 Jim Blandy <jimb@redhat.com>
>> >
>> > * s390-tdep.c (s390_readinstruction): Don't call
>> > info->read_memory_func to read zero bytes. Some targets'
>> > xfer_memory functions can't cope with that.
>> >
>
>>
>>
>> Jim, which?
>>
>> While slightly stupid, the target should be able to handle that.
>
>
> Oh, wait, I understand now.
>
> A target's to_xfer_memory function is supposed to return the number of
> bytes transferred, or zero if it can't transfer the bytes. If you
> make a zero-length request, there's no way for it to indicate success.
> D'oh!
Can you file a CR against this stupidity? I'll add it to my list of
things to untangle.
Andrew
prev parent reply other threads:[~2001-12-23 9:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-20 0:56 Jim Blandy
2001-12-20 3:10 ` Andrew Cagney
2001-12-20 12:53 ` Jim Blandy
2001-12-20 12:57 ` Jim Blandy
2001-12-23 1:44 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C259803.6090007@cygnus.com \
--to=ac131313@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox