Re: [PATCH] Improved support for overlay breakpoints in ROM

[Jim Blandy <jimb@zwingli.cygnus.com>]

Michael Snyder <msnyder@redhat.com> writes:

> Jim Blandy wrote:
> > 
> > Typo:
> > 
> > > +     /* On the same principal, an overlay manager can arrange to call a
> > 
> > s/principal/principle/
> > 
> > It seems to me that, if overlay management is disabled, or set to
> > `manual', we shouldn't even set a breakpoint in _ovly_debug_event.
> 
> By analogy with the longjmp breakpoint, it seems easiest just to 
> create the breakpoint when the symbol file is loaded, and then
> enable/disable it as needed.  When it is disabled, it doesn't
> represent any significant overhead.

Okay, I see.

> > We need to document the new rules in the GDB manual.
> 
> Yep.  

... How can we prevent this from falling through the cracks?  I don't
mind doing it, but I'm afraid I'm going to forget.