From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16870 invoked by alias); 6 Feb 2002 04:17:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16712 invoked from network); 6 Feb 2002 04:17:19 -0000 Received: from unknown (HELO zwingli.cygnus.com) (208.245.165.35) by sources.redhat.com with SMTP; 6 Feb 2002 04:17:19 -0000 Received: by zwingli.cygnus.com (Postfix, from userid 442) id E83FB5E9DE; Tue, 5 Feb 2002 23:18:53 -0500 (EST) To: Michael Snyder Cc: Michael Snyder , gdb-patches@sources.redhat.com, ezannoni@redhat.com Subject: Re: [PATCH] Improved support for overlay breakpoints in ROM References: <200202050011.g150BfB21148@reddwarf.cygnus.com> <3C608108.C7BA0407@redhat.com> From: Jim Blandy Date: Tue, 05 Feb 2002 20:17:00 -0000 In-Reply-To: <3C608108.C7BA0407@redhat.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-02/txt/msg00153.txt.bz2 Michael Snyder writes: > Jim Blandy wrote: > > > > Typo: > > > > > + /* On the same principal, an overlay manager can arrange to call a > > > > s/principal/principle/ > > > > It seems to me that, if overlay management is disabled, or set to > > `manual', we shouldn't even set a breakpoint in _ovly_debug_event. > > By analogy with the longjmp breakpoint, it seems easiest just to > create the breakpoint when the symbol file is loaded, and then > enable/disable it as needed. When it is disabled, it doesn't > represent any significant overhead. Okay, I see. > > We need to document the new rules in the GDB manual. > > Yep. ... How can we prevent this from falling through the cracks? I don't mind doing it, but I'm afraid I'm going to forget.