From: Jim Blandy <jimb@zwingli.cygnus.com>
To: Daniel Berlin <dan@cgsoftware.com>
Cc: Charlie Mills <cmills@synopsys.com>, gdb-patches@sourceware.cygnus.com
Subject: Re: Simple but crucial bug fix to gdb
Date: Fri, 01 Jun 2001 14:17:00 -0000 [thread overview]
Message-ID: <nphexzlx0j.fsf@zwingli.cygnus.com> (raw)
In-Reply-To: <87hexzaozu.fsf@dynamic-addr-83-177.resnet.rochester.edu>
Daniel Berlin <dan@cgsoftware.com> writes:
> Err, isn't this a memory leak?
>
> You never free the name after complaining.
>
> Same below
2001-06-01 Jim Blandy <jimb@redhat.com>
* partial-stab.h (case N_FUN: case 'f':, case N_FUN: case 'F':)
Fix memory leak.
Index: partial-stab.h
===================================================================
RCS file: /cvs/src/src/gdb/partial-stab.h,v
retrieving revision 1.10
diff -c -r1.10 partial-stab.h
*** partial-stab.h 2001/06/01 20:37:11 1.10
--- partial-stab.h 2001/06/01 21:16:36
***************
*** 586,591 ****
--- 586,592 ----
memcpy (name, namestring, name_len);
name[name_len] = '\0';
complain (&function_outside_compilation_unit, name);
+ xfree (name);
}
CUR_SYMBOL_VALUE += ANOFFSET (objfile->section_offsets, SECT_OFF_TEXT (objfile));
#ifdef DBXREAD_ONLY
***************
*** 640,645 ****
--- 641,647 ----
memcpy (name, namestring, name_len);
name[name_len] = '\0';
complain (&function_outside_compilation_unit, name);
+ xfree (name);
}
CUR_SYMBOL_VALUE += ANOFFSET (objfile->section_offsets, SECT_OFF_TEXT (objfile));
#ifdef DBXREAD_ONLY
prev parent reply other threads:[~2001-06-01 14:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-30 14:27 Charlie Mills
2001-05-30 14:36 ` Christopher Faylor
2001-05-30 15:16 ` Fernando Nasser
2001-05-30 20:18 ` Jim Blandy
2001-05-30 20:25 ` Christopher Faylor
2001-05-31 5:30 ` Fernando Nasser
2001-05-31 13:55 ` Jim Blandy
2001-05-31 14:43 ` Fernando Nasser
2001-05-31 16:46 ` Christopher Faylor
2001-05-31 17:40 ` Daniel Berlin
2001-05-31 20:00 ` Frank Ch. Eigler
2001-06-01 9:41 ` Fernando Nasser
2001-06-01 10:01 ` Michael Snyder
2001-06-01 11:14 ` Daniel Berlin
2001-06-01 11:25 ` Fernando Nasser
2001-06-01 14:05 ` Charlie Mills
2001-06-06 6:01 ` Andrew Cagney
2001-05-30 20:00 ` Christopher Faylor
2001-05-30 20:43 ` Christopher Faylor
2001-05-30 20:12 ` Jim Blandy
2001-05-30 21:23 ` Daniel Berlin
2001-06-01 13:35 ` Jim Blandy
2001-06-01 13:41 ` Fernando Nasser
2001-06-01 14:07 ` Daniel Berlin
2001-06-01 14:15 ` Jim Blandy
2001-06-01 14:17 ` Jim Blandy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nphexzlx0j.fsf@zwingli.cygnus.com \
--to=jimb@zwingli.cygnus.com \
--cc=cmills@synopsys.com \
--cc=dan@cgsoftware.com \
--cc=gdb-patches@sourceware.cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox