Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Fernando Nasser <fnasser@cygnus.com>
To: Jim Blandy <jimb@cygnus.com>
Cc: Fernando Nasser <fnasser@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: Simple but crucial bug fix to gdb
Date: Thu, 31 May 2001 14:43:00 -0000	[thread overview]
Message-ID: <3B16BAEB.2AD12D2E@cygnus.com> (raw)
In-Reply-To: <npelt5me4f.fsf@zwingli.cygnus.com>

Jim Blandy wrote:
> 
> There's something very odd (or, as Daniel would have me say, even
> odder than usual) going on here.  Rather than slap a test for null
> over the problem and have it disappear, I want to try to understand
> what's going on.
> 

Sure.  I agree with that.

How about adding a warning() (with code to print it only once per object file that has this problem) so it does not go unnoticed?   The test for pst could still be there as defensive programming about crazy compilers (if this is what is causing the problem).

This way we would do both: prevent the core dump without hiding the problem.


P.S.: Unfortunately this code is "included" inside a loop, which makes the warning-once part awkward.  

P.S.2: Being "included" also prevents me to follow things with Source Navigator :-)   It could be made a function with 10 arguments (END_PSYMTAB and START_PSYMTAB would have to be turned into callbacks) instead.  I can do this in a rainy day if you like the idea.




-- 
Fernando Nasser
Red Hat - Toronto                       E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9


  reply	other threads:[~2001-05-31 14:43 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-30 14:27 Charlie Mills
2001-05-30 14:36 ` Christopher Faylor
2001-05-30 15:16   ` Fernando Nasser
2001-05-30 20:18     ` Jim Blandy
2001-05-30 20:25       ` Christopher Faylor
2001-05-31  5:30       ` Fernando Nasser
2001-05-31 13:55         ` Jim Blandy
2001-05-31 14:43           ` Fernando Nasser [this message]
2001-05-31 16:46           ` Christopher Faylor
2001-05-31 17:40             ` Daniel Berlin
2001-05-31 20:00               ` Frank Ch. Eigler
2001-06-01  9:41                 ` Fernando Nasser
2001-06-01 10:01                 ` Michael Snyder
2001-06-01 11:14                   ` Daniel Berlin
2001-06-01 11:25                     ` Fernando Nasser
2001-06-01 14:05                       ` Charlie Mills
2001-06-06  6:01                 ` Andrew Cagney
2001-05-30 20:00   ` Christopher Faylor
2001-05-30 20:43     ` Christopher Faylor
2001-05-30 20:12 ` Jim Blandy
2001-05-30 21:23   ` Daniel Berlin
2001-06-01 13:35 ` Jim Blandy
2001-06-01 13:41   ` Fernando Nasser
2001-06-01 14:07   ` Daniel Berlin
2001-06-01 14:15     ` Jim Blandy
2001-06-01 14:17     ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3B16BAEB.2AD12D2E@cygnus.com \
    --to=fnasser@cygnus.com \
    --cc=fnasser@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox