Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: Andrew Cagney <ac131313@ges.redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFC: initial TLS patch
Date: Mon, 08 Jul 2002 20:15:00 -0000	[thread overview]
Message-ID: <npbs9h61mp.fsf@zwingli.cygnus.com> (raw)
In-Reply-To: <3D2A4811.9000908@ges.redhat.com>


Andrew Cagney <ac131313@ges.redhat.com> writes:
> > + extern struct so_list *get_solib_by_objfile (struct objfile *OBJFILE);
> >
> >> Tipo OBJFILE -> objfile.
> > It was capitalized to match the comment above:
> > + /* Return the so_list entry whose object file is OBJFILE.  */
> > + extern struct so_list *get_solib_by_objfile (struct objfile *OBJFILE);
> > + But the rest of GDB doesn't do that, so I'll change this.
> 
> Just FYI, from the coding doco:
> 
> > The comment on a function is much clearer if you use the argument
> > names to speak about the argument values. The variable name itself
> > should be lower case, but write it in upper case when you are
> > speaking about the value rather than the variable itself. Thus, "the
> > inode number NODE_NUM" rather than "an inode".

Chapter and verse, indeed.  Already fixed.


      reply	other threads:[~2002-07-09  3:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-02  8:23 Jim Blandy
2002-07-02 10:08 ` Daniel Berlin
2002-07-03  2:39 ` Michael Snyder
2002-07-03 13:10   ` Jim Blandy
2002-07-03  8:28 ` Andrew Cagney
2002-07-03 11:30   ` Jim Blandy
2002-07-08 19:19     ` Andrew Cagney
2002-07-08 20:48       ` Jim Blandy
2002-07-08 20:06     ` Andrew Cagney
2002-07-08 20:15       ` Jim Blandy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=npbs9h61mp.fsf@zwingli.cygnus.com \
    --to=jimb@redhat.com \
    --cc=ac131313@ges.redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox