From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14843 invoked by alias); 9 Jul 2002 03:06:42 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14825 invoked from network); 9 Jul 2002 03:06:41 -0000 Received: from unknown (HELO zwingli.cygnus.com) (208.245.165.35) by sources.redhat.com with SMTP; 9 Jul 2002 03:06:41 -0000 Received: by zwingli.cygnus.com (Postfix, from userid 442) id 28FBC5EA11; Mon, 8 Jul 2002 22:06:38 -0500 (EST) To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: RFC: initial TLS patch References: <3D23129A.8070207@ges.redhat.com> <3D2A4811.9000908@ges.redhat.com> From: Jim Blandy Date: Mon, 08 Jul 2002 20:15:00 -0000 In-Reply-To: <3D2A4811.9000908@ges.redhat.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-07/txt/msg00133.txt.bz2 Andrew Cagney writes: > > + extern struct so_list *get_solib_by_objfile (struct objfile *OBJFILE); > > > >> Tipo OBJFILE -> objfile. > > It was capitalized to match the comment above: > > + /* Return the so_list entry whose object file is OBJFILE. */ > > + extern struct so_list *get_solib_by_objfile (struct objfile *OBJFILE); > > + But the rest of GDB doesn't do that, so I'll change this. > > Just FYI, from the coding doco: > > > The comment on a function is much clearer if you use the argument > > names to speak about the argument values. The variable name itself > > should be lower case, but write it in upper case when you are > > speaking about the value rather than the variable itself. Thus, "the > > inode number NODE_NUM" rather than "an inode". Chapter and verse, indeed. Already fixed.