From: Andreas Schwab <schwab@linux-m68k.org>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/hppa-tdep.c: Fix a logical typo bug found by compiler warning
Date: Thu, 16 Oct 2014 07:06:00 -0000 [thread overview]
Message-ID: <mvmh9z45w8s.fsf@hawking.suse.de> (raw)
In-Reply-To: <d6q0acpdxmm7g52oqylkjjb2.1413419448973@email.android.com> (Chen Gang's message of "Thu, 16 Oct 2014 08:30:49 +0800")
There's another bug in this function:
/* Does it look like a stw? */
if ((inst >> 26) == 0x1a || (inst >> 26) == 0x1b
|| (inst >> 26) == 0x1f
|| ((inst >> 26) == 0x1f
&& ((inst >> 6) == 0xa)))
return hppa_extract_5R_store (inst);
The last condition is redundant.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next parent reply other threads:[~2014-10-16 7:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <d6q0acpdxmm7g52oqylkjjb2.1413419448973@email.android.com>
2014-10-16 7:06 ` Andreas Schwab [this message]
2014-10-16 7:38 ` Chen Gang
2014-10-14 21:21 Chen Gang
2014-10-14 21:29 ` Andreas Schwab
2014-10-14 21:43 ` Chen Gang
2014-10-15 15:00 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmh9z45w8s.fsf@hawking.suse.de \
--to=schwab@linux-m68k.org \
--cc=brobecker@adacore.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox