From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24850 invoked by alias); 16 Oct 2014 07:06:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24835 invoked by uid 89); 16 Oct 2014 07:06:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: mail-out.m-online.net Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 16 Oct 2014 07:06:49 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3jJM455Mkrz3hjBW; Thu, 16 Oct 2014 09:06:45 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3jJM446rvbzvdWF; Thu, 16 Oct 2014 09:06:44 +0200 (CEST) Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id dH9QHlKaaAJa; Thu, 16 Oct 2014 09:06:43 +0200 (CEST) X-Auth-Info: diMRm4aNNYyS9qe1k8sTg25IcC39olRNDlf4SreUF6cick/jALDRIlnVUyNuOjDM Received: from hawking.suse.de (nat.nue.novell.com [195.135.221.2]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 16 Oct 2014 09:06:43 +0200 (CEST) From: Andreas Schwab To: Chen Gang Cc: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/hppa-tdep.c: Fix a logical typo bug found by compiler warning References: X-Yow: Spreading peanut butter reminds me of opera!! I wonder why? Date: Thu, 16 Oct 2014 07:06:00 -0000 In-Reply-To: (Chen Gang's message of "Thu, 16 Oct 2014 08:30:49 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-10/txt/msg00417.txt.bz2 There's another bug in this function: /* Does it look like a stw? */ if ((inst >> 26) == 0x1a || (inst >> 26) == 0x1b || (inst >> 26) == 0x1f || ((inst >> 26) == 0x1f && ((inst >> 6) == 0xa))) return hppa_extract_5R_store (inst); The last condition is redundant. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."