From: "Nathan J. Williams" <nathanw@wasabisystems.com>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC/RFA] target.c: Check current_target in target_resize_to_sections
Date: Fri, 27 Aug 2004 14:57:00 -0000 [thread overview]
Message-ID: <mtu7jrkocgn.fsf@contents-vnder-pressvre.mit.edu> (raw)
In-Reply-To: <412E5516.6050209@gnu.org>
Andrew Cagney <cagney@gnu.org> writes:
> > 2004-08-25 Nathan J. Williams <nathanw@wasabisystems.com>
> > * target.c (target_resize_to_sections): Check
> > current_target.to_sections for an old value when updating.
>
> Can you just add some sort of brief comment noting why current_target
> also needs to be checked. With that it's ok (but post the revised
> patch when committing).
Sure. Should I add the comment to the ChangeLog, the code, or both?
(The code already says what it's trying to do by updating all this
stuff, and while it's not obvious when something like current_target
is missing, it's pretty obvious when it's there).
- Nathan
next prev parent reply other threads:[~2004-08-27 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-25 20:40 Nathan J. Williams
2004-08-26 21:25 ` Andrew Cagney
2004-08-27 14:57 ` Nathan J. Williams [this message]
2004-08-27 15:13 ` Andrew Cagney
2004-08-27 18:12 ` Nathan J. Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mtu7jrkocgn.fsf@contents-vnder-pressvre.mit.edu \
--to=nathanw@wasabisystems.com \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox