From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2513 invoked by alias); 27 Aug 2004 14:57:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2316 invoked from network); 27 Aug 2004 14:57:47 -0000 Received: from unknown (HELO biscayne-one-station.mit.edu) (18.7.7.80) by sourceware.org with SMTP; 27 Aug 2004 14:57:47 -0000 Received: from melbourne-city-street.mit.edu (MELBOURNE-CITY-STREET.MIT.EDU [18.7.21.86]) by biscayne-one-station.mit.edu (8.12.4/8.9.2) with ESMTP id i7REvkxd026168; Fri, 27 Aug 2004 10:57:46 -0400 (EDT) Received: from contents-vnder-pressvre.mit.edu (CONTENTS-VNDER-PRESSVRE.MIT.EDU [18.7.16.67]) (authenticated bits=56) (User authenticated as nathanw@ATHENA.MIT.EDU) by melbourne-city-street.mit.edu (8.12.4/8.12.4) with ESMTP id i7REvjuv012246 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 27 Aug 2004 10:57:45 -0400 (EDT) Received: (from nathanw@localhost) by contents-vnder-pressvre.mit.edu (8.12.9) id i7REvjPR015818; Fri, 27 Aug 2004 10:57:45 -0400 (EDT) To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC/RFA] target.c: Check current_target in target_resize_to_sections References: <412E5516.6050209@gnu.org> From: "Nathan J. Williams" Organization: Wasabi Systems, Inc. Date: Fri, 27 Aug 2004 14:57:00 -0000 In-Reply-To: <412E5516.6050209@gnu.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-08/txt/msg00740.txt.bz2 Andrew Cagney writes: > > 2004-08-25 Nathan J. Williams > > * target.c (target_resize_to_sections): Check > > current_target.to_sections for an old value when updating. > > Can you just add some sort of brief comment noting why current_target > also needs to be checked. With that it's ok (but post the revised > patch when committing). Sure. Should I add the comment to the ChangeLog, the code, or both? (The code already says what it's trying to do by updating all this stuff, and while it's not obvious when something like current_target is missing, it's pretty obvious when it's there). - Nathan