From: Palmer Dabbelt <palmer@sifive.com>
To: andrew.burgess@embecosm.com
Cc: gdb-patches@sourceware.org, Jim Wilson <jimw@sifive.com>,
jhb@FreeBSD.org, andrew.burgess@embecosm.com
Subject: Re: [PATCH] gdb/riscv: Update test to handle targets without an fpu
Date: Sat, 08 Dec 2018 20:25:00 -0000 [thread overview]
Message-ID: <mhng-cf8f7b0f-670d-4e16-875f-2f09258a728d@palmer-si-x1c4> (raw)
In-Reply-To: <20181204132934.26104-1-andrew.burgess@embecosm.com>
On Tue, 04 Dec 2018 05:29:34 PST (-0800), andrew.burgess@embecosm.com wrote:
> The FPU is optional on RISC-V. The gdb.base/float.exp test currently
> assumes that an fpu is always available on RISC-V. Update the test so
> that this is not the case.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.base/float.exp: Handle RISC-V targets without an FPU.
> ---
> gdb/testsuite/ChangeLog | 4 ++++
> gdb/testsuite/gdb.base/float.exp | 10 +++++++++-
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.base/float.exp b/gdb/testsuite/gdb.base/float.exp
> index 71d3f60c499..23d68a13dfc 100644
> --- a/gdb/testsuite/gdb.base/float.exp
> +++ b/gdb/testsuite/gdb.base/float.exp
> @@ -111,7 +111,15 @@ if { [is_aarch64_target] } then {
> } elseif [istarget "sparc*-*-*"] then {
> gdb_test "info float" "f0.*f1.*f31.*d0.*d30.*" "info float"
> } elseif [istarget "riscv*-*-*"] then {
> - gdb_test "info float" "ft0.*ft1.*ft11.*fflags.*frm.*fcsr.*" "info float"
> + # RISC-V may or may not have an FPU
> + gdb_test_multiple "info float" "info float" {
> + -re "ft0.*ft1.*ft11.*fflags.*frm.*fcsr.*$gdb_prompt $" {
> + pass "info float (with FPU)"
> + }
> + -re "No floating.point info available for this processor.*$gdb_prompt $" {
> + pass "info float (without FPU)"
> + }
> + }
> } else {
> gdb_test "info float" "No floating.point info available for this processor." "info float (unknown target)"
> }
Thanks!
prev parent reply other threads:[~2018-12-08 20:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 13:29 Andrew Burgess
2018-12-08 20:25 ` Palmer Dabbelt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-cf8f7b0f-670d-4e16-875f-2f09258a728d@palmer-si-x1c4 \
--to=palmer@sifive.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
--cc=jimw@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox