Re: [PATCH] Fix PR bootstrap/42798

[Ian Lance Taylor <iant@google.com>]

Ralf Wildenhues <Ralf.Wildenhues@gmx.de> writes:

> This is the followup patch for src.  Tested by building binutils+gdb,
> I'm starting a combined tree with --enable-build-with-cxx now.
> Ok to commit if no problems show up?
>
> A note to the gold change: I've looked at git glibc headers, of the
> declarations tested only 'basename' was overloaded.  If more are added
> in the future, the configure.ac files need to be adjusted to give
> parameters for them, too.  This applies to the whole tree of course for
> --enable-build-with-cxx, not just for gold.

With regard to the gold change.  What will happen if the system header
files provide only a declaration
    char *basename(const char *)
?

Since gold doesn't actually basename, another option here would be to
skip the check of the basename declaration entirely.  In fact, we
should consider dropping basename from libiberty; our code should in
general use lbasename anyhow.

Ian