From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3076 invoked by alias); 4 Jun 2010 14:59:27 -0000 Received: (qmail 3054 invoked by uid 22791); 4 Jun 2010 14:59:23 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,TW_CX,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Jun 2010 14:59:14 +0000 Received: from kpbe12.cbf.corp.google.com (kpbe12.cbf.corp.google.com [172.25.105.76]) by smtp-out.google.com with ESMTP id o54ExCvT010900; Fri, 4 Jun 2010 07:59:12 -0700 Received: from pwi6 (pwi6.prod.google.com [10.241.219.6]) by kpbe12.cbf.corp.google.com with ESMTP id o54ExBmv031249; Fri, 4 Jun 2010 07:59:11 -0700 Received: by pwi6 with SMTP id 6so197910pwi.14 for ; Fri, 04 Jun 2010 07:59:10 -0700 (PDT) Received: by 10.141.105.3 with SMTP id h3mr9107754rvm.196.1275663550685; Fri, 04 Jun 2010 07:59:10 -0700 (PDT) Received: from coign.google.com ([67.218.104.7]) by mx.google.com with ESMTPS id b1sm2500464rvn.2.2010.06.04.07.59.07 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 04 Jun 2010 07:59:08 -0700 (PDT) To: Ralf Wildenhues Cc: Paolo Bonzini , binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH] Fix PR bootstrap/42798 References: <20100601204405.GA1170@gmx.de> <20100602111845.GA16161@ins.uni-bonn.de> <4C064B77.3020207@gnu.org> <20100603063319.GC28276@gmx.de> <20100603065852.GA28617@gmx.de> From: Ian Lance Taylor Date: Fri, 04 Jun 2010 14:59:00 -0000 In-Reply-To: <20100603065852.GA28617@gmx.de> (Ralf Wildenhues's message of "Thu\, 3 Jun 2010 08\:58\:57 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-System-Of-Record: true Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00117.txt.bz2 Ralf Wildenhues writes: > This is the followup patch for src. Tested by building binutils+gdb, > I'm starting a combined tree with --enable-build-with-cxx now. > Ok to commit if no problems show up? > > A note to the gold change: I've looked at git glibc headers, of the > declarations tested only 'basename' was overloaded. If more are added > in the future, the configure.ac files need to be adjusted to give > parameters for them, too. This applies to the whole tree of course for > --enable-build-with-cxx, not just for gold. With regard to the gold change. What will happen if the system header files provide only a declaration char *basename(const char *) ? Since gold doesn't actually basename, another option here would be to skip the check of the basename declaration entirely. In fact, we should consider dropping basename from libiberty; our code should in general use lbasename anyhow. Ian