From: Tom Tromey <tromey@redhat.com>
To: Samuel Bronson <naesten@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] * cli/cli-decode.c (apropos_cmd): Fix avoidance of double printing.
Date: Wed, 17 Jun 2009 17:26:00 -0000 [thread overview]
Message-ID: <m3zlc6wz3q.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1245209405-9539-1-git-send-email-naesten@gmail.com> (Samuel Bronson's message of "Tue\, 16 Jun 2009 23\:30\:04 -0400")
>>>>> "Samuel" == Samuel Bronson <naesten@gmail.com> writes:
Samuel> Signed-off-by: Samuel Bronson <naesten@gmail.com>
Samuel> ---
Samuel> gdb/cli/cli-decode.c | 4 ++--
Samuel> 1 files changed, 2 insertions(+), 2 deletions(-)
Needs a ChangeLog entry...
Samuel> - int returnvalue=1; /*Needed to avoid double printing*/
Samuel> + int returnvalue=-1; /*Needed to avoid double printing*/
Samuel> /* Walk through the commands */
Samuel> for (c=commandlist;c;c=c->next)
Samuel> {
Shouldn't this reinitialize returnvalue to -1 each time through the
loop?
Tom
next prev parent reply other threads:[~2009-06-17 17:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 3:31 Samuel Bronson
2009-06-17 3:31 ` [PATCH 2/2] * cli/cli-decode.c (apropos_cmd): Skip traversing abbreviations for prefix commands to avoid duplicates in the output Samuel Bronson
2009-06-17 17:27 ` Tom Tromey
2009-06-17 17:26 ` Tom Tromey [this message]
2009-06-17 20:15 ` [PATCH 1/2] * cli/cli-decode.c (apropos_cmd): Fix avoidance of double printing Samuel Bronson
2009-06-17 22:22 ` [PATCH 1/2] Fix for PR gdb/9903 (part 1) Samuel Bronson
2009-06-17 22:23 ` [PATCH 2/2] Fix for PR gdb/9903 (part 2) Samuel Bronson
2009-06-18 17:59 ` [PATCH 1/2] Fix for PR gdb/9903 (part 1) Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zlc6wz3q.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=naesten@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox