From: Tom Tromey <tromey@redhat.com>
To: Samuel Bronson <naesten@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Fix for PR gdb/9903 (part 1)
Date: Thu, 18 Jun 2009 17:59:00 -0000 [thread overview]
Message-ID: <m3ocsltoci.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1245277318-12742-1-git-send-email-naesten@gmail.com> (Samuel Bronson's message of "Wed\, 17 Jun 2009 18\:21\:57 -0400")
>>>>> "Samuel" == Samuel Bronson <naesten@gmail.com> writes:
Samuel> * cli/cli-decode.c (apropos_cmd): Fix avoidance of double
Samuel> printing.
These two patches look good to me. Since they are very small I will
commit them (a bit later). However, future patches, regardless of
size, will have to wait for your paperwork to clear.
In a case like this, where someone else is committing the patch, it is
simpler for us if you send a complete ChangeLog entry, including the
header. (Or if not simpler, it is at least traditional :-)
Also in this particular case I would add the PR number to the
entry. Like:
2009-06-17 Samuel Bronson <naesten@gmail.com>
PR cli/9930:
* cli/cli-decode.c (apropos_cmd): Fix avoidance of double
printing.
This addition means that the commit message will automatically be
logged in bugzilla.
Tom
prev parent reply other threads:[~2009-06-18 17:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 3:31 [PATCH 1/2] * cli/cli-decode.c (apropos_cmd): Fix avoidance of double printing Samuel Bronson
2009-06-17 3:31 ` [PATCH 2/2] * cli/cli-decode.c (apropos_cmd): Skip traversing abbreviations for prefix commands to avoid duplicates in the output Samuel Bronson
2009-06-17 17:27 ` Tom Tromey
2009-06-17 17:26 ` [PATCH 1/2] * cli/cli-decode.c (apropos_cmd): Fix avoidance of double printing Tom Tromey
2009-06-17 20:15 ` Samuel Bronson
2009-06-17 22:22 ` [PATCH 1/2] Fix for PR gdb/9903 (part 1) Samuel Bronson
2009-06-17 22:23 ` [PATCH 2/2] Fix for PR gdb/9903 (part 2) Samuel Bronson
2009-06-18 17:59 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ocsltoci.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=naesten@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox