From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit] Fix crash of gdb save-index on a STABS file
Date: Thu, 14 Apr 2011 20:44:00 -0000 [thread overview]
Message-ID: <m3zknsef6b.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20110409152300.GA13143@host1.jankratochvil.net> (Jan Kratochvil's message of "Sat, 9 Apr 2011 17:23:00 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> There are some concerns what is a file uses both DWARF and STABS,
Jan> it may possibly currently have a regression with .gdb_index. But
Jan> that is unrelated to this patch.
I think it should all work. At least, I designed it to.
The index itself is written by looking at the CUs in the objfile's
dwarf2_per_objfile. So, I think the index should not reference any
psymtabs coming from STABS.
On the reader side, the code in elfread.c is written to read STABS
first -- and skip using the index if any are found. This handles the
problem that an objfile can only have one set of quick functions.
This is expensive, but people mixing in this way deserve it ;-)
Tom
next prev parent reply other threads:[~2011-04-14 20:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-09 15:23 Jan Kratochvil
2011-04-14 20:44 ` Tom Tromey [this message]
2011-04-17 16:32 ` [patch+7.3] gdbindex regression: stabs forgotten [Fix crash of gdb save-index on a STABS file] Jan Kratochvil
2011-04-18 17:31 ` Tom Tromey
2011-04-23 4:53 ` [wrong patch] Re: [patch+7.3] gdbindex regression: stabs forgotten Jan Kratochvil
2011-04-25 16:02 ` Tom Tromey
2011-04-23 5:15 ` Jan Kratochvil
2011-04-25 16:03 ` Tom Tromey
2011-04-25 19:41 ` Jan Kratochvil
2011-04-25 20:49 ` Joel Brobecker
2011-04-25 21:28 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zknsef6b.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox