From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10720 invoked by alias); 14 Apr 2011 20:44:38 -0000 Received: (qmail 10709 invoked by uid 22791); 14 Apr 2011 20:44:38 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Apr 2011 20:44:30 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3EKiTg0004886 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 14 Apr 2011 16:44:29 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p3EKiTke028909; Thu, 14 Apr 2011 16:44:29 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p3EKiSbW020641; Thu, 14 Apr 2011 16:44:29 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id A6C3C37831C; Thu, 14 Apr 2011 14:44:28 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [commit] Fix crash of gdb save-index on a STABS file References: <20110409152300.GA13143@host1.jankratochvil.net> Date: Thu, 14 Apr 2011 20:44:00 -0000 In-Reply-To: <20110409152300.GA13143@host1.jankratochvil.net> (Jan Kratochvil's message of "Sat, 9 Apr 2011 17:23:00 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00210.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> There are some concerns what is a file uses both DWARF and STABS, Jan> it may possibly currently have a regression with .gdb_index. But Jan> that is unrelated to this patch. I think it should all work. At least, I designed it to. The index itself is written by looking at the CUs in the objfile's dwarf2_per_objfile. So, I think the index should not reference any psymtabs coming from STABS. On the reader side, the code in elfread.c is written to read STABS first -- and skip using the index if any are found. This handles the problem that an objfile can only have one set of quick functions. This is expensive, but people mixing in this way deserve it ;-) Tom