Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@codesourcery.com>
To: muller@ics.u-strasbg.fr
Cc: gdb-patches@sourceware.org
Subject: Re: PATCH: Add 'static' keyword
Date: Thu, 26 Oct 2006 21:13:00 -0000	[thread overview]
Message-ID: <m3y7r2bx1a.fsf@codesourcery.com> (raw)
In-Reply-To: <17854.57.67.16.50.1161816856.squirrel@websd.u-strasbg.fr> (Pierre Muller's message of "Thu, 26 Oct 2006 00:54:16 +0200 (CEST)")


"Pierre Muller" <muller@ics.u-strasbg.fr> writes:
>    The problem is that I am not really a confirmed C code writer,
> I basically started C programming to add pascal language
> support in GDB.
>    The same kind of error could be repeated in several
> other locations, I did not even think that it was
> a good practice to repeat 'static' in the implementation.
>
>   Don't hesitate to correct others.

Thanks!  It's no big problem.  I did look at the other functions, and
it seemed fine.

I was looking into correcting the warnings produced by the stock
Fedora Core 5 compiler --- I understand the warnings don't occur any
more, but copying around obstack structures is gross --- but when I
realized I didn't have a pascal compiler installed to test the change
anyway, I lost enthusiasm for the change.

So all GDB got in the end was one 'static'.  :(


      reply	other threads:[~2006-10-26 21:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-25 21:27 Jim Blandy
2006-10-25 22:54 ` Pierre Muller
2006-10-26 21:13   ` Jim Blandy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3y7r2bx1a.fsf@codesourcery.com \
    --to=jimb@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=muller@ics.u-strasbg.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox