From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12418 invoked by alias); 26 Oct 2006 21:13:37 -0000 Received: (qmail 12410 invoked by uid 22791); 26 Oct 2006 21:13:37 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 26 Oct 2006 21:13:35 +0000 Received: (qmail 6356 invoked from network); 26 Oct 2006 21:13:33 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 26 Oct 2006 21:13:33 -0000 To: muller@ics.u-strasbg.fr Cc: gdb-patches@sourceware.org Subject: Re: PATCH: Add 'static' keyword References: <17854.57.67.16.50.1161816856.squirrel@websd.u-strasbg.fr> From: Jim Blandy Date: Thu, 26 Oct 2006 21:13:00 -0000 In-Reply-To: <17854.57.67.16.50.1161816856.squirrel@websd.u-strasbg.fr> (Pierre Muller's message of "Thu, 26 Oct 2006 00:54:16 +0200 (CEST)") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00286.txt.bz2 "Pierre Muller" writes: > The problem is that I am not really a confirmed C code writer, > I basically started C programming to add pascal language > support in GDB. > The same kind of error could be repeated in several > other locations, I did not even think that it was > a good practice to repeat 'static' in the implementation. > > Don't hesitate to correct others. Thanks! It's no big problem. I did look at the other functions, and it seemed fine. I was looking into correcting the warnings produced by the stock Fedora Core 5 compiler --- I understand the warnings don't occur any more, but copying around obstack structures is gross --- but when I realized I didn't have a pascal compiler installed to test the change anyway, I lost enthusiasm for the change. So all GDB got in the end was one 'static'. :(