From: Tom Tromey <tromey@redhat.com>
To: Sterling Augustine <saugustine@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [Patch] More responsive QUITs
Date: Fri, 22 Jul 2011 01:14:00 -0000 [thread overview]
Message-ID: <m3y5zrz7q8.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CAEG7qUynN3k1zkWU6qLOKr0DY8sby5ovqVukNArmFZo_4UW3iA@mail.gmail.com> (Sterling Augustine's message of "Wed, 20 Jul 2011 11:22:18 -0700")
>>>>> "Sterling" == Sterling Augustine <saugustine@google.com> writes:
Sterling> 2011-07-20 Sterling Augustine <saugustine@google.com>
Sterling> * psymtab.c (map_symbol_filenames_psymtab): Call QUIT.
I think this exposes gdb to a memory leak in
make_source_files_completion_list.
I think the bug is a QUIT can unwind:
map_symbol_filenames_psymtab
-> map_partial_symbol_filenames
-> make_source_files_completion_list
... which does not use cleanups to protect the allocations it does.
Tom
next prev parent reply other threads:[~2011-07-21 20:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 3:03 Sterling Augustine
2011-07-15 20:49 ` Tom Tromey
2011-07-20 18:46 ` Sterling Augustine
2011-07-22 1:14 ` Tom Tromey [this message]
[not found] ` <CAEG7qUxKevmBX=oCXr2p+x-zi-ZbBGLf3Gmb-X2bnVBpf7VKGA@mail.gmail.com>
[not found] ` <m3wrf6qeii.fsf@fleche.redhat.com>
2011-07-25 21:07 ` Sterling Augustine
2011-07-25 21:41 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3y5zrz7q8.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=saugustine@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox