From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82505-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26694 invoked by alias); 21 Jul 2011 20:42:23 -0000
Received: (qmail 26684 invoked by uid 22791); 21 Jul 2011 20:42:23 -0000
X-SWARE-Spam-Status: No, hits=-7.5 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Jul 2011 20:42:10 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6LKg9v0031774	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 21 Jul 2011 16:42:09 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p6LKg81c010855;	Thu, 21 Jul 2011 16:42:08 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6LKg7MA027480;	Thu, 21 Jul 2011 16:42:07 -0400
From: Tom Tromey <tromey@redhat.com>
To: Sterling Augustine <saugustine@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [Patch] More responsive QUITs
References: <CAEG7qUyG6S3pFiXsC2uyiPm8-WSexXBF64Gy+ARnF-wb30uKEA@mail.gmail.com>	<m3wrfj9sr2.fsf@fleche.redhat.com>	<CAEG7qUynN3k1zkWU6qLOKr0DY8sby5ovqVukNArmFZo_4UW3iA@mail.gmail.com>
Date: Fri, 22 Jul 2011 01:14:00 -0000
In-Reply-To: <CAEG7qUynN3k1zkWU6qLOKr0DY8sby5ovqVukNArmFZo_4UW3iA@mail.gmail.com>	(Sterling Augustine's message of "Wed, 20 Jul 2011 11:22:18 -0700")
Message-ID: <m3y5zrz7q8.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-07/txt/msg00600.txt.bz2

>>>>> "Sterling" == Sterling Augustine <saugustine@google.com> writes:

Sterling> 2011-07-20  Sterling Augustine  <saugustine@google.com>
Sterling>        * psymtab.c (map_symbol_filenames_psymtab): Call QUIT.

I think this exposes gdb to a memory leak in
make_source_files_completion_list.

I think the bug is a QUIT can unwind:

   map_symbol_filenames_psymtab
-> map_partial_symbol_filenames
-> make_source_files_completion_list

... which does not use cleanups to protect the allocations it does.

Tom