From: Tom Tromey <tromey@redhat.com>
To: Andrew Pinski <andrew.pinski@caviumnetworks.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix linespec.c vs padding on 32bit targets
Date: Fri, 09 Dec 2011 15:54:00 -0000 [thread overview]
Message-ID: <m3y5ulg3db.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CA+=Sn1km=U-HzHLednrV0V5d5eZ9gjqFOgcpRmgaryVd_=TSyg@mail.gmail.com> (Andrew Pinski's message of "Thu, 8 Dec 2011 19:49:56 -0800")
>>>>> "Andrew" == Andrew Pinski <andrew.pinski@caviumnetworks.com> writes:
Andrew> The problem here is there is padding in address_entry so
Andrew> iterative_hash_object on the full object cannot be done as the padding
Andrew> would be some junk. This causes lots of gdb failures on
Andrew> mips64-linux-gnu.
Thanks Andrew.
Andrew> OK? Tested on mips64-linux-gnu.
One tiny nit, see below.
Andrew> PS I don't have write access for gdb.
If you have write access to binutils then you do.
If you still don't, let me know and I will commit it.
Andrew> + hashval_t hash;
Andrew> + hash = iterative_hash_object (aep->pspace, 0);
Andrew> + return iterative_hash_object (aep->addr, hash);
The gdb style puts a blank line between declarations and code.
Ok with that change.
Tom
next prev parent reply other threads:[~2011-12-09 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 5:40 Andrew Pinski
2011-12-09 15:54 ` Tom Tromey [this message]
2011-12-09 19:53 ` Andrew Pinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3y5ulg3db.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=andrew.pinski@caviumnetworks.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox