From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-85971-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13511 invoked by alias); 9 Dec 2011 15:41:03 -0000
Received: (qmail 13502 invoked by uid 22791); 9 Dec 2011 15:41:03 -0000
X-SWARE-Spam-Status: No, hits=-7.6 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Dec 2011 15:40:35 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pB9FeYIW009129	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 9 Dec 2011 10:40:34 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pB9FeYuk029354;	Fri, 9 Dec 2011 10:40:34 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pB9FeWWe018863;	Fri, 9 Dec 2011 10:40:33 -0500
From: Tom Tromey <tromey@redhat.com>
To: Andrew Pinski <andrew.pinski@caviumnetworks.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix linespec.c vs padding on 32bit targets
References: <CA+=Sn1km=U-HzHLednrV0V5d5eZ9gjqFOgcpRmgaryVd_=TSyg@mail.gmail.com>
Date: Fri, 09 Dec 2011 15:54:00 -0000
In-Reply-To: <CA+=Sn1km=U-HzHLednrV0V5d5eZ9gjqFOgcpRmgaryVd_=TSyg@mail.gmail.com>	(Andrew Pinski's message of "Thu, 8 Dec 2011 19:49:56 -0800")
Message-ID: <m3y5ulg3db.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-12/txt/msg00290.txt.bz2

>>>>> "Andrew" == Andrew Pinski <andrew.pinski@caviumnetworks.com> writes:

Andrew>   The problem here is there is padding in address_entry so
Andrew> iterative_hash_object on the full object cannot be done as the padding
Andrew> would be some junk.  This causes lots of gdb failures on
Andrew> mips64-linux-gnu.

Thanks Andrew.

Andrew> OK?  Tested on mips64-linux-gnu.

One tiny nit, see below.

Andrew> PS I don't have write access for gdb.

If you have write access to binutils then you do.
If you still don't, let me know and I will commit it.

Andrew> +  hashval_t hash;
Andrew> +  hash = iterative_hash_object (aep->pspace, 0);
Andrew> +  return iterative_hash_object (aep->addr, hash);

The gdb style puts a blank line between declarations and code.
Ok with that change.

Tom