Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: [7.7.1] Blocker patch (GCC 4.9 compat)
Date: Thu, 24 Apr 2014 22:39:00 -0000	[thread overview]
Message-ID: <m3y4yu73p9.fsf@redhat.com> (raw)

Hi Joel,

I tested the GDB 7.7 branch using GCC 4.9 to build it, and found some
errors.

  In file included from ../../gdb/defs.h:104:0,
                   from ../../gdb/cli/cli-dump.c:22:
  ../../gdb/cli/cli-dump.c: In function 'dump_bfd_file':
  ../bfd/bfd.h:302:108: error: right-hand operand of comma expression has no effect [-Werror=unused-value]
   #define bfd_set_section_vma(bfd, ptr, val) (((ptr)->vma = (ptr)->lma = (val)), ((ptr)->user_set_vma = TRUE), TRUE)
                                                                                                              ^
  ../../gdb/cli/cli-dump.c:197:3: note: in expansion of macro 'bfd_set_section_vma'
     bfd_set_section_vma (obfd, osection, vaddr);
     ^
  ../bfd/bfd.h:303:83: error: right-hand operand of comma expression has no effect [-Werror=unused-value]
   #define bfd_set_section_alignment(bfd, ptr, val) (((ptr)->alignment_power = (val)),TRUE)
                                                                                     ^
  ../../gdb/cli/cli-dump.c:198:3: note: in expansion of macro 'bfd_set_section_alignment'
     bfd_set_section_alignment (obfd, osection, 0);

They have been fixed by the following commit:

  commit 27b829ee701e29804216b3803fbaeb629be27491
  Author: Nick Clifton <nickc@redhat.com>
  Date:   Wed Jan 29 13:46:39 2014 +0000

So I am proposing that we backport this commit to the 7.7 branch.  I can
do that if it is OK.

WDYT?  Thanks,

-- 
Sergio


             reply	other threads:[~2014-04-24 22:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-24 22:39 Sergio Durigan Junior [this message]
2014-04-24 22:48 ` Joel Brobecker
2014-04-24 23:20   ` Sergio Durigan Junior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3y4yu73p9.fsf@redhat.com \
    --to=sergiodj@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox