From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch][python] Merge missing type block functionality
Date: Thu, 25 Feb 2010 18:39:00 -0000 [thread overview]
Message-ID: <m3wry1qhwa.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100225171727.GA10788@localhost.localdomain> (Phil Muldoon's message of "Thu, 25 Feb 2010 17:17:28 +0000")
>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
Phil> In the recent block, symbol and symbol table merge, I missed some
Phil> functionality in py-type. This patch adds that functionality from the
Phil> archer branch.
Phil> What do you think?
One nit...
Phil> + PyErr_SetString (PyExc_RuntimeError,
Phil> + "second argument must be block");
I think the string should be wrapped in _().
Phil> + PyErr_SetString (PyExc_RuntimeError,
Phil> + "'block' argument must be a Block");
Likewise.
With this change the code bits are ok.
Please put your name in the ChangeLog entry.
Tom
next prev parent reply other threads:[~2010-02-25 18:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 17:17 Phil Muldoon
2010-02-25 18:39 ` Tom Tromey [this message]
2010-02-28 22:10 ` Phil Muldoon
2010-02-25 19:40 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3wry1qhwa.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox