From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70470-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30234 invoked by alias); 25 Feb 2010 18:39:41 -0000
Received: (qmail 30220 invoked by uid 22791); 25 Feb 2010 18:39:40 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 25 Feb 2010 18:39:36 +0000
Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1PIdZpR010559 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) 	for <gdb-patches@sourceware.org>; Thu, 25 Feb 2010 13:39:35 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1PIdZJq008312; 	Thu, 25 Feb 2010 13:39:35 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o1PIdYF2002675; 	Thu, 25 Feb 2010 13:39:34 -0500
Received: by opsy.redhat.com (Postfix, from userid 500) 	id BF10E378261; Thu, 25 Feb 2010 11:39:33 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch][python] Merge missing type block functionality
References: <20100225171727.GA10788@localhost.localdomain>
Reply-To: tromey@redhat.com
Date: Thu, 25 Feb 2010 18:39:00 -0000
In-Reply-To: <20100225171727.GA10788@localhost.localdomain> (Phil Muldoon's 	message of "Thu, 25 Feb 2010 17:17:28 +0000")
Message-ID: <m3wry1qhwa.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-02/txt/msg00629.txt.bz2

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> In the recent block, symbol and symbol table merge, I missed some
Phil> functionality in py-type.  This patch adds that functionality from the
Phil> archer branch.

Phil> What do you think?

One nit...

Phil> +	  PyErr_SetString (PyExc_RuntimeError,
Phil> +			   "second argument must be block");

I think the string should be wrapped in _().

Phil> +	  PyErr_SetString (PyExc_RuntimeError,
Phil> +			   "'block' argument must be a Block");

Likewise.

With this change the code bits are ok.
Please put your name in the ChangeLog entry.

Tom