From: Tom Tromey <tromey@redhat.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Re-parse display expressions if architecture changes
Date: Mon, 21 Dec 2009 20:32:00 -0000 [thread overview]
Message-ID: <m3vdg09ifj.fsf@fleche.redhat.com> (raw)
In-Reply-To: <200912211533.nBLFX5ux028195@d12av02.megacenter.de.ibm.com> (Ulrich Weigand's message of "Mon, 21 Dec 2009 16:33:05 +0100 (CET)")
>>>>> "Ulrich" == Ulrich Weigand <uweigand@de.ibm.com> writes:
Ulrich> The patch below implements this by ensuring the expression is
Ulrich> re-parsed if the currnet architecture is different from the one
Ulrich> the expression was originally parsed in.
This seems like a reasonable idea to me.
Ulrich> Any comments? I'm planning to apply this next week.
I think this needs to xfree the old expression to avoid a memory leak.
Tom
next prev parent reply other threads:[~2009-12-21 20:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-21 15:33 Ulrich Weigand
2009-12-21 20:32 ` Tom Tromey [this message]
2009-12-22 14:12 ` Ulrich Weigand
2010-01-04 15:05 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vdg09ifj.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox