From: Tom Tromey <tromey@redhat.com>
To: Greg Watson <g.watson@computer.org>
Cc: gdb-patches@sourceware.org
Subject: Re: Improve handling of Fortran keywords
Date: Tue, 14 Dec 2010 17:41:00 -0000 [thread overview]
Message-ID: <m3vd2wqmkl.fsf@fleche.redhat.com> (raw)
In-Reply-To: <5503A4B2-EB18-40A9-9182-27E05D73D0EF@computer.org> (Greg Watson's message of "Tue, 14 Dec 2010 11:18:16 -0500")
>>>>> "Greg" == Greg Watson <g.watson@computer.org> writes:
Greg> Currently, gdb 7.2 will not allow me to use identifier names such
Greg> as "integer_var" as it treats the first "integer" part as a
Greg> keyword without checking that the identifier is actually longer
Greg> than the keyword. Here's a simple patch to fix this (and make
Greg> Fortran debugging more useful).
Could you try this patch instead?
I think it should have the same effect, but it is simpler.
Tom
diff --git a/gdb/f-exp.y b/gdb/f-exp.y
index 415819a..487b00d 100644
--- a/gdb/f-exp.y
+++ b/gdb/f-exp.y
@@ -1150,8 +1150,7 @@ yylex ()
/* Catch specific keywords. */
for (i = 0; f77_keywords[i].operator != NULL; i++)
- if (strncmp (tokstart, f77_keywords[i].operator,
- strlen(f77_keywords[i].operator)) == 0)
+ if (strncmp (tokstart, f77_keywords[i].operator, namelen)) == 0)
{
/* lexptr += strlen(f77_keywords[i].operator); */
yylval.opcode = f77_keywords[i].opcode;
next prev parent reply other threads:[~2010-12-14 17:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 16:18 Greg Watson
2010-12-14 17:41 ` Tom Tromey [this message]
2010-12-15 18:52 ` Greg Watson
2010-12-15 19:28 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vd2wqmkl.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=g.watson@computer.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox