From: Greg Watson <g.watson@computer.org>
To: gdb-patches@sourceware.org
Subject: Improve handling of Fortran keywords
Date: Tue, 14 Dec 2010 16:18:00 -0000 [thread overview]
Message-ID: <5503A4B2-EB18-40A9-9182-27E05D73D0EF@computer.org> (raw)
Hi,
Currently, gdb 7.2 will not allow me to use identifier names such as "integer_var" as it treats the first "integer" part as a keyword without checking that the identifier is actually longer than the keyword. Here's a simple patch to fix this (and make Fortran debugging more useful).
Regards,
Greg
*** f-exp.y.orig 2010-12-14 10:28:34.542834692 -0500
--- f-exp.y 2010-12-14 11:06:04.798853514 -0500
***************
*** 955,960 ****
--- 955,961 ----
{
int c;
int namelen;
+ int keylen;
unsigned int i,token;
char *tokstart;
***************
*** 1149,1162 ****
/* Catch specific keywords. */
! for (i = 0; f77_keywords[i].operator != NULL; i++)
! if (strncmp (tokstart, f77_keywords[i].operator,
! strlen(f77_keywords[i].operator)) == 0)
{
/* lexptr += strlen(f77_keywords[i].operator); */
yylval.opcode = f77_keywords[i].opcode;
return f77_keywords[i].token;
}
yylval.sval.ptr = tokstart;
yylval.sval.length = namelen;
--- 1150,1165 ----
/* Catch specific keywords. */
! for (i = 0; f77_keywords[i].operator != NULL; i++) {
! keylen = strlen(f77_keywords[i].operator);
! if (strlen(tokstart) == keylen &&
! strncmp (tokstart, f77_keywords[i].operator, keylen) == 0)
{
/* lexptr += strlen(f77_keywords[i].operator); */
yylval.opcode = f77_keywords[i].opcode;
return f77_keywords[i].token;
}
+ }
yylval.sval.ptr = tokstart;
yylval.sval.length = namelen;
next reply other threads:[~2010-12-14 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 16:18 Greg Watson [this message]
2010-12-14 17:41 ` Tom Tromey
2010-12-15 18:52 ` Greg Watson
2010-12-15 19:28 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5503A4B2-EB18-40A9-9182-27E05D73D0EF@computer.org \
--to=g.watson@computer.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox