From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Joel Brobecker <brobecker@adacore.com>
Subject: Re: [RFA v2] valprint.c / *-valprint.c: Don't lose `embedded_offset'
Date: Fri, 28 Jan 2011 11:35:00 -0000 [thread overview]
Message-ID: <m3vd19gt7p.fsf@fleche.redhat.com> (raw)
In-Reply-To: <201101241322.42902.pedro@codesourcery.com> (Pedro Alves's message of "Mon, 24 Jan 2011 13:22:42 +0000")
>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
Pedro> In the context of tracepoints, I'm adding support for
Pedro> partial/incomplete objects.
This sound tantalizingly close to the sparse value thing we were talking
about recently.
Pedro> The comment is actually not 100% correct or clear. It's actually
Pedro> data of type TYPE located at VALADDR + EMBEDDED_OFFSET, which
Pedro> came from the inferior at address ADDRESS + EMBEDDED_OFFSET.
Pedro> ORIGINAL_VALUE, if non-NULL, is what came from ADDRESS. (the
Pedro> patch doesn't fix this; there are a bunch of copies of that
Pedro> comment around, and I want to fix them all in one go in a
Pedro> followup, or maybe in a next revision of this patch).
Or maybe nuke them all and have a single comment describing the
"val_print protocol" somewhere. These duplicated comments always end up
rotting.
Thanks for doing this.
Tom
prev parent reply other threads:[~2011-01-28 11:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 13:24 Pedro Alves
2011-01-24 16:56 ` Pedro Alves
2011-01-24 17:37 ` Joel Brobecker
2011-01-24 19:39 ` Pedro Alves
2011-01-24 19:46 ` Pedro Alves
2011-01-24 21:06 ` Joel Brobecker
2011-01-24 19:47 ` Pedro Alves
2011-01-28 11:35 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vd19gt7p.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox