From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 698 invoked by alias); 28 Jan 2011 11:32:18 -0000 Received: (qmail 690 invoked by uid 22791); 28 Jan 2011 11:32:17 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Jan 2011 11:32:07 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0SBVeRX001789 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 28 Jan 2011 06:31:40 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p0SBVdA8014426; Fri, 28 Jan 2011 06:31:39 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p0SBVcbk026002; Fri, 28 Jan 2011 06:31:39 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 9AB373784E2; Fri, 28 Jan 2011 04:31:38 -0700 (MST) From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org, Joel Brobecker Subject: Re: [RFA v2] valprint.c / *-valprint.c: Don't lose `embedded_offset' References: <201101241322.42902.pedro@codesourcery.com> Date: Fri, 28 Jan 2011 11:35:00 -0000 In-Reply-To: <201101241322.42902.pedro@codesourcery.com> (Pedro Alves's message of "Mon, 24 Jan 2011 13:22:42 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00539.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> In the context of tracepoints, I'm adding support for Pedro> partial/incomplete objects. This sound tantalizingly close to the sparse value thing we were talking about recently. Pedro> The comment is actually not 100% correct or clear. It's actually Pedro> data of type TYPE located at VALADDR + EMBEDDED_OFFSET, which Pedro> came from the inferior at address ADDRESS + EMBEDDED_OFFSET. Pedro> ORIGINAL_VALUE, if non-NULL, is what came from ADDRESS. (the Pedro> patch doesn't fix this; there are a bunch of copies of that Pedro> comment around, and I want to fix them all in one go in a Pedro> followup, or maybe in a next revision of this patch). Or maybe nuke them all and have a single comment describing the "val_print protocol" somewhere. These duplicated comments always end up rotting. Thanks for doing this. Tom