From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: RFC: remove a bunch of testsuite/**/configure scripts
Date: Mon, 28 Feb 2011 22:03:00 -0000 [thread overview]
Message-ID: <m3vd037t85.fsf@fleche.redhat.com> (raw)
I plan to check this in soon.
While working on something unrelated, I ran across some weirdness in
gdb/testsuite Makefiles. Digging a little deeper, I found a bunch of
configure scripts in subdirectories. These scripts don't do anything
useful, so this patch removes all of them.
I also removed some of the individual rules to rebuild Makefiles. These
rules never worked correctly.
Built and regtested on x86-64 (compile farm).
I'd like to go a few step farther and remove both testsuite/configure
and all the Makefile.in's, but the latter at least were recently updated
to make "make clean" work, so I'm a little reluctant to do this.
I omitted the removed files from the appended.
Tom
2011-02-28 Tom Tromey <tromey@redhat.com>
* gdb.hp/gdb.aCC/Makefile.in (Makefile): Remove.
* gdb.hp/gdb.aCC/configure (Makefile): Remove.
* gdb.hp/gdb.aCC/configure.ac: Remove.
* gdb.hp/gdb.base-hp/Makefile.in (Makefile): Remove.
* gdb.hp/gdb.base-hp/configure (Makefile): Remove.
* gdb.hp/gdb.base-hp/configure.ac: Remove.
* gdb.hp/gdb.compat/Makefile.in (Makefile): Remove.
* gdb.hp/gdb.compat/configure (Makefile): Remove.
* gdb.hp/gdb.compat/configure.ac: Remove.
* gdb.hp/gdb.defects/Makefile.in (Makefile): Remove.
* gdb.hp/gdb.defects/configure (Makefile): Remove.
* gdb.hp/gdb.defects/configure.ac: Remove.
* gdb.hp/gdb.objdbg/Makefile.in (Makefile): Remove.
* gdb.hp/gdb.objdbg/configure (Makefile): Remove.
* gdb.hp/gdb.objdbg/configure.ac: Remove.
* gdb.hp/configure.ac: Remove.
* gdb.hp/configure: Remove.
* gdb.hp/Makefile.in (SUBDIRS): No longer a configure
substitution.
(Makefile): Remove rule.
* gdb.cell/configure.ac: Remove.
* gdb.cell/configure: Remove.
* gdb.stabs/Makefile.in (Makefile): Remove.
(distclean): Don't remove config.status or config.log.
* gdb.stabs/configure (Makefile): Remove.
* gdb.stabs/configure.ac: Remove.
* configure: Rebuild.
* configure.ac: Don't AC_CONFIG_HEADER in gdb.hp or gdb.stabs.
Remove stabs-specific logic. Test for existence of ../gdbtk
before configuring gdb.gdbtk. Build Makefiles in gdb.hp
subdirectories and gdb.stabs.
* Makefile.in (ALL_SUBDIRS): Add gdb.hp and gdb.stabs.
diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in
index 17d0b1a..3d6bf42 100644
--- a/gdb/testsuite/Makefile.in
+++ b/gdb/testsuite/Makefile.in
@@ -34,9 +34,10 @@ EXEEXT = @EXEEXT@
SUBDIRS = @subdirs@
RPATH_ENVVAR = @RPATH_ENVVAR@
ALL_SUBDIRS = gdb.ada gdb.arch gdb.asm gdb.base gdb.cell gdb.cp gdb.disasm \
- gdb.dwarf2 gdb.fortran gdb.gdb gdb.java gdb.mi gdb.modula2 gdb.multi \
+ gdb.dwarf2 gdb.fortran gdb.gdb gdb.hp \
+ gdb.java gdb.mi gdb.modula2 gdb.multi \
gdb.objc gdb.opencl gdb.opt gdb.pascal gdb.python gdb.server \
- gdb.reverse gdb.threads gdb.trace gdb.xml \
+ gdb.stabs gdb.reverse gdb.threads gdb.trace gdb.xml \
$(SUBDIRS)
EXPECT = `if [ -f $${rootme}/../../expect/expect ] ; then \
diff --git a/gdb/testsuite/gdb.hp/Makefile.in b/gdb/testsuite/gdb.hp/Makefile.in
index 3bcceaf..a2b1b8f 100644
--- a/gdb/testsuite/gdb.hp/Makefile.in
+++ b/gdb/testsuite/gdb.hp/Makefile.in
@@ -1,7 +1,7 @@
VPATH = @srcdir@
srcdir = @srcdir@
-SUBDIRS = @subdirs@
+SUBDIRS = gdb.aCC gdb.base-hp gdb.compat gdb.defects gdb.objdbg
all:
@echo "Nothing to be done for all..."
@@ -39,6 +39,3 @@ distclean maintainer-clean realclean: clean
fi; \
done ; \
else true; fi
-
-Makefile: $(srcdir)/Makefile.in $(srcdir)/configure.in
- $(SHELL) ./config.status --recheck
diff --git a/gdb/testsuite/gdb.hp/gdb.aCC/Makefile.in b/gdb/testsuite/gdb.hp/gdb.aCC/Makefile.in
index 1295c1e..dbfca95 100644
--- a/gdb/testsuite/gdb.hp/gdb.aCC/Makefile.in
+++ b/gdb/testsuite/gdb.hp/gdb.aCC/Makefile.in
@@ -22,6 +22,3 @@ distclean maintainer-clean realclean: clean
-rm -f Makefile config.status config.log
-rm -f *-init.exp
-rm -fr *.log summary detail *.plog *.sum *.psum site.*
-
-Makefile : $(srcdir)/Makefile.in $(srcdir)/configure.in
- $(SHELL) ./config.status --recheck
diff --git a/gdb/testsuite/gdb.hp/gdb.base-hp/Makefile.in b/gdb/testsuite/gdb.hp/gdb.base-hp/Makefile.in
index adbde9d..2254ab4 100644
--- a/gdb/testsuite/gdb.hp/gdb.base-hp/Makefile.in
+++ b/gdb/testsuite/gdb.hp/gdb.base-hp/Makefile.in
@@ -27,6 +27,3 @@ distclean maintainer-clean realclean: clean
-rm -f Makefile config.status config.log
-rm -f *-init.exp
-rm -fr *.log summary detail *.plog *.sum *.psum site.*
-
-Makefile : $(srcdir)/Makefile.in $(srcdir)/configure.in
- $(SHELL) ./config.status --recheck
diff --git a/gdb/testsuite/gdb.hp/gdb.compat/Makefile.in b/gdb/testsuite/gdb.hp/gdb.compat/Makefile.in
index ada0f1a..b74fa65 100644
--- a/gdb/testsuite/gdb.hp/gdb.compat/Makefile.in
+++ b/gdb/testsuite/gdb.hp/gdb.compat/Makefile.in
@@ -22,6 +22,3 @@ distclean maintainer-clean realclean: clean
-rm -f Makefile config.status config.log
-rm -f *-init.exp
-rm -fr *.log summary detail *.plog *.sum *.psum site.*
-
-Makefile : $(srcdir)/Makefile.in $(srcdir)/configure.in
- $(SHELL) ./config.status --recheck
diff --git a/gdb/testsuite/gdb.hp/gdb.defects/Makefile.in b/gdb/testsuite/gdb.hp/gdb.defects/Makefile.in
index f0a7858..b1a9284 100644
--- a/gdb/testsuite/gdb.hp/gdb.defects/Makefile.in
+++ b/gdb/testsuite/gdb.hp/gdb.defects/Makefile.in
@@ -22,6 +22,3 @@ distclean maintainer-clean realclean: clean
-rm -f Makefile config.status config.log
-rm -f *-init.exp
-rm -fr *.log summary detail *.plog *.sum *.psum site.*
-
-Makefile : $(srcdir)/Makefile.in $(srcdir)/configure.in
- $(SHELL) ./config.status --recheck
diff --git a/gdb/testsuite/gdb.hp/gdb.objdbg/Makefile.in b/gdb/testsuite/gdb.hp/gdb.objdbg/Makefile.in
index 5411c46..229f3ae 100644
--- a/gdb/testsuite/gdb.hp/gdb.objdbg/Makefile.in
+++ b/gdb/testsuite/gdb.hp/gdb.objdbg/Makefile.in
@@ -23,6 +23,3 @@ distclean maintainer-clean realclean: clean
-rm -f Makefile config.status config.log
-rm -f *-init.exp
-rm -fr *.log summary detail *.plog *.sum *.psum site.*
-
-Makefile : $(srcdir)/Makefile.in $(srcdir)/configure.in
- $(SHELL) ./config.status --recheck
diff --git a/gdb/testsuite/gdb.stabs/Makefile.in b/gdb/testsuite/gdb.stabs/Makefile.in
index ff470ed..7d5755c 100644
--- a/gdb/testsuite/gdb.stabs/Makefile.in
+++ b/gdb/testsuite/gdb.stabs/Makefile.in
@@ -10,7 +10,4 @@ clean mostlyclean:
-rm -f *.o *~ core tmp.c tmp.s weird.s errs exclfwd gdb11479
distclean maintainer-clean realclean: clean
- -rm -f Makefile config.status config.log gdb.log gdb.sum
-
-Makefile: $(srcdir)/Makefile.in $(srcdir)/configure.ac
- $(SHELL) ./config.status --recheck
+ -rm -f Makefile gdb.log gdb.sum
next reply other threads:[~2011-02-28 21:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 22:03 Tom Tromey [this message]
2011-02-28 22:11 ` Andreas Schwab
2011-03-01 17:15 ` Tom Tromey
2011-03-01 4:53 ` Joel Brobecker
2011-03-01 17:20 ` Tom Tromey
2011-03-03 16:57 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vd037t85.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox