From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: remove a bunch of testsuite/**/configure scripts
Date: Tue, 01 Mar 2011 17:20:00 -0000 [thread overview]
Message-ID: <m3ipw269my.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20110301045303.GI30306@adacore.com> (Joel Brobecker's message of "Tue, 1 Mar 2011 08:53:03 +0400")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> I'm in favor of at least removing the configure script. For
Joel> the Makefiles (would we keep the master one in gdb/testsuite/?,
Either way is ok.
I think there is probably enough code in testsuite/Makefile.in to
warrant keeping it around. Ordinarily I think it is better, for
parallelism, to have as few Makefiles as possible, but that doesn't seem
like a real consideration in this case.
Joel> I'd say yes, at least as a first step), it's a tougher one. I think
Joel> it depends on what the consequences in terms of funtionality would
Joel> be. I don't mind losing "make clean" capability in the testsuite
Joel> area, but that might be problems for those who build in-tree
Joel> (sacrilege! :-).
All these Makefiles exist only for "make clean".
Until Michael's patch last week, they didn't even successfully do that :-)
In fact, depending on the target, that may still be the case; I don't
know for certain but I suspect so.
I wonder whether we could arrange to invoke runtest in a subdirectory.
Then "make clean" would be "rm -rf testdir".
This would break "clean" for those people invoking runtest by hand though.
Personally I never run "make clean" for the testsuite and I really
couldn't care less if it stopped working. Is there anybody who does
care and rely on this? If you do use it -- why? I would rather not go
through a bunch of gyrations for a feature that no developer uses.
Tom
next prev parent reply other threads:[~2011-03-01 17:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 22:03 Tom Tromey
2011-02-28 22:11 ` Andreas Schwab
2011-03-01 17:15 ` Tom Tromey
2011-03-01 4:53 ` Joel Brobecker
2011-03-01 17:20 ` Tom Tromey [this message]
2011-03-03 16:57 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ipw269my.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox