From: Tom Tromey <tromey@redhat.com>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [RFA] Fix segfault on Python convenience functions which call GDB commands
Date: Thu, 12 May 2011 20:19:00 -0000 [thread overview]
Message-ID: <m3vcxfk6yq.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1305085747.2308.72.camel@hactar> (Thiago Jung Bauermann's message of "Wed, 11 May 2011 00:49:07 -0300")
>>>>> "Thiago" == Thiago Jung Bauermann <bauerman@br.ibm.com> writes:
Thiago> 2011-05-11 Thiago Jung Bauermann <bauerman@br.ibm.com>
Thiago> gdb/
Thiago> * mi/mi-main.c (mi_cmd_execute): Use cleanup from
Thiago> prepare_execute_command.
Thiago> top.c (prepare_execute_command): Return cleanup.
Thiago> (execute_command): Use cleanup from prepare_execute_command.
Thiago> * top.h (prepare_execute_command): Change prototype to return
Thiago> cleanup.
Thiago> * defs.h (struct value): Add opaque declaration.
Thiago> (make_cleanup_value_free_to_mark): Add prototype.
Thiago> * utils.c (do_value_free_to_mark): New function.
Thiago> (make_cleanup_value_free_to_mark): Likewise.
Looks good.
Just one tiny nit.
Thiago> +extern struct cleanup * make_cleanup_value_free_to_mark (struct value *);
Extra space after the "*".
Ok with this change.
Tom
next prev parent reply other threads:[~2011-05-12 20:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 3:49 Thiago Jung Bauermann
2011-05-12 20:19 ` Tom Tromey [this message]
2011-05-13 4:37 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vcxfk6yq.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=bauerman@br.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox