From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11891 invoked by alias); 12 May 2011 20:19:28 -0000 Received: (qmail 11878 invoked by uid 22791); 12 May 2011 20:19:28 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 May 2011 20:19:14 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4CKJBbn018915 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 12 May 2011 16:19:11 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p4CKJBOE012698; Thu, 12 May 2011 16:19:11 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p4CKJAIH002022; Thu, 12 May 2011 16:19:10 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id DBF2B37848C; Thu, 12 May 2011 14:19:09 -0600 (MDT) From: Tom Tromey To: Thiago Jung Bauermann Cc: gdb-patches ml Subject: Re: [RFA] Fix segfault on Python convenience functions which call GDB commands References: <1305085747.2308.72.camel@hactar> Date: Thu, 12 May 2011 20:19:00 -0000 In-Reply-To: <1305085747.2308.72.camel@hactar> (Thiago Jung Bauermann's message of "Wed, 11 May 2011 00:49:07 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00313.txt.bz2 >>>>> "Thiago" == Thiago Jung Bauermann writes: Thiago> 2011-05-11 Thiago Jung Bauermann Thiago> gdb/ Thiago> * mi/mi-main.c (mi_cmd_execute): Use cleanup from Thiago> prepare_execute_command. Thiago> top.c (prepare_execute_command): Return cleanup. Thiago> (execute_command): Use cleanup from prepare_execute_command. Thiago> * top.h (prepare_execute_command): Change prototype to return Thiago> cleanup. Thiago> * defs.h (struct value): Add opaque declaration. Thiago> (make_cleanup_value_free_to_mark): Add prototype. Thiago> * utils.c (do_value_free_to_mark): New function. Thiago> (make_cleanup_value_free_to_mark): Likewise. Looks good. Just one tiny nit. Thiago> +extern struct cleanup * make_cleanup_value_free_to_mark (struct value *); Extra space after the "*". Ok with this change. Tom