Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: FYI: fix 2 tests when glibc debuginfo is installed
Date: Fri, 14 Oct 2011 16:05:00 -0000	[thread overview]
Message-ID: <m3vcrreezx.fsf@fleche.redhat.com> (raw)

I'm checking this in.

I found a couple of tests that work by accident when glibc debuginfo is
installed.

First, when running attach-stopped.exp:

    break 30
    Breakpoint 1 at 0x3a160d2d30: file ../sysdeps/unix/syscall-template.S, line 63. (7 locations)

This is not what is intended:

    # This breakpoint is there for old/non-x86 kernels not restarting syscalls.
    gdb_breakpoint [gdb_get_line_number "Second sleep"]

Second, attachstop-mt.exp:

    break 30
    Breakpoint 1 at 0x3a160d2d30: file ../sysdeps/unix/syscall-template.S, line 63. (7 locations)

Again:

    gdb_breakpoint [gdb_get_line_number "cut the sleep time"]

The fix is to add $srcfile to the linespec.

Tom

2011-10-14  Tom Tromey  <tromey@redhat.com>

	* gdb.threads/attachstop-mt.exp: Add $srcfile to the linespecs.
	* gdb.threads/attach-stopped.exp (corefunc): Add $srcfile to the
	linespec.

Index: gdb.threads/attach-stopped.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/attach-stopped.exp,v
retrieving revision 1.6
diff -u -r1.6 attach-stopped.exp
--- gdb.threads/attach-stopped.exp	1 Jan 2011 15:33:50 -0000	1.6
+++ gdb.threads/attach-stopped.exp	14 Oct 2011 16:03:49 -0000
@@ -78,7 +78,7 @@
 	gdb_test "bt" ".*sleep.*main.*" "$threadtype: attach2 to stopped bt"
     }
     # This breakpoint is there for old/non-x86 kernels not restarting syscalls.
-    gdb_breakpoint [gdb_get_line_number "Second sleep"]
+    gdb_breakpoint $srcfile:[gdb_get_line_number "Second sleep"]
     set test "$threadtype: attach2 continue"
     gdb_test_multiple "continue" "continue ($test)" {
 	-re "Continuing" {
Index: gdb.threads/attachstop-mt.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/attachstop-mt.exp,v
retrieving revision 1.7
diff -u -r1.7 attachstop-mt.exp
--- gdb.threads/attachstop-mt.exp	1 Jan 2011 15:33:50 -0000	1.7
+++ gdb.threads/attachstop-mt.exp	14 Oct 2011 16:03:49 -0000
@@ -208,8 +208,8 @@
 gdb_test "bt" ".*sleep.*(func|main).*" "attach4 to stopped bt"
 
 # RHEL3U8 kernel-2.4.21-47.EL will not return SIGINT but only shorten the sleep.
-gdb_breakpoint [gdb_get_line_number "Ridiculous time"]
-gdb_breakpoint [gdb_get_line_number "cut the sleep time"]
+gdb_breakpoint $srcfile:[gdb_get_line_number "Ridiculous time"]
+gdb_breakpoint $srcfile:[gdb_get_line_number "cut the sleep time"]
 set test "attach4 continue"
 gdb_test_multiple "continue" "continue ($test)" {
     -re "Continuing" {


             reply	other threads:[~2011-10-14 16:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-14 16:05 Tom Tromey [this message]
2011-10-14 19:37 ` Jan Kratochvil
2011-10-14 21:19   ` Pedro Alves
2011-10-14 21:25     ` Jan Kratochvil
2011-10-14 21:42       ` Pedro Alves
2011-10-15 14:52         ` Oleg Nesterov
2011-10-25 17:03           ` Pedro Alves
2011-10-25 17:38             ` Oleg Nesterov
2011-10-25 18:16               ` Pedro Alves
2011-10-25 18:38                 ` Oleg Nesterov
2011-10-25 19:50                   ` Pedro Alves
2011-10-16 16:41       ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3vcrreezx.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox