From: Doug Evans <xdje42@gmail.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] Add some const-ness to py-cmd.c
Date: Sun, 08 Dec 2013 08:05:00 -0000 [thread overview]
Message-ID: <m3vbyzydik.fsf@sspiff.org> (raw)
Hi.
When can we drop support for older Python versions?
2013-12-08 Doug Evans <xdje42@gmail.com>
* python/py-cmd.c (struct cmdpy_completer): Add comment.
(completers): Make const.
diff --git a/gdb/python/py-cmd.c b/gdb/python/py-cmd.c
index c0e9d96..c845c7c 100644
--- a/gdb/python/py-cmd.c
+++ b/gdb/python/py-cmd.c
@@ -32,13 +32,15 @@
/* Struct representing built-in completion types. */
struct cmdpy_completer
{
- /* Python symbol name. */
+ /* Python symbol name.
+ This isn't a const char * for Python 2.4's sake.
+ PyModule_AddIntConstant only takes a char *, sigh. */
char *name;
/* Completion function. */
completer_ftype *completer;
};
-static struct cmdpy_completer completers[] =
+static const struct cmdpy_completer completers[] =
{
{ "COMPLETE_NONE", noop_completer },
{ "COMPLETE_FILENAME", filename_completer },
next reply other threads:[~2013-12-08 8:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-08 8:05 Doug Evans [this message]
2013-12-09 10:39 ` Phil Muldoon
2013-12-10 20:57 ` Tom Tromey
2013-12-11 3:24 ` Tom Tromey
2013-12-11 7:53 ` Joel Brobecker
2013-12-11 8:11 ` Jan Kratochvil
2013-12-11 15:12 ` Tom Tromey
2013-12-11 15:36 ` Joel Brobecker
2013-12-11 15:43 ` Tom Tromey
2013-12-11 15:56 ` Joel Brobecker
2013-12-11 15:57 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vbyzydik.fsf@sspiff.org \
--to=xdje42@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox