Re: [PATCH] Add some const-ness to py-cmd.c

[Phil Muldoon <pmuldoon@redhat.com>]

On 08/12/13 08:04, Doug Evans wrote:
> Hi.
> 
> When can we drop support for older Python versions?
> 
> 2013-12-08  Doug Evans  <xdje42@gmail.com>
> 
> 	* python/py-cmd.c (struct cmdpy_completer): Add comment.
> 	(completers): Make const.
> 
> diff --git a/gdb/python/py-cmd.c b/gdb/python/py-cmd.c
> index c0e9d96..c845c7c 100644
> --- a/gdb/python/py-cmd.c
> +++ b/gdb/python/py-cmd.c
> @@ -32,13 +32,15 @@
>  /* Struct representing built-in completion types.  */
>  struct cmdpy_completer
>  {
> -  /* Python symbol name.  */
> +  /* Python symbol name.
> +     This isn't a const char * for Python 2.4's sake.
> +     PyModule_AddIntConstant only takes a char *, sigh.  */
>    char *name;
>    /* Completion function.  */
>    completer_ftype *completer;
>  };
>  
> -static struct cmdpy_completer completers[] =
> +static const struct cmdpy_completer completers[] =
>  {
>    { "COMPLETE_NONE", noop_completer },
>    { "COMPLETE_FILENAME", filename_completer },
> 

It's really up to our downstream packagers.  It can't be soon enough
for me.  I spend an inordinate amount of time checking my code (both C
and Python works on 2.4 -> 3.x).  It is really a time consuming and
tedious task.

My thoughts are that from GDB version x.x, we declare from then on we
only support Python 3.x, and if your distribution does not support
Python 3.x to revert GDB to an older version.

I suspect though that his would encounter some resistance from the
folks who work in the enterprise sector, as I doubt various
enterprise systems have updated to Python 3.x.

tl;dr  We should probably ask around.

Cheers,

Phil