Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@codesourcery.com>
To: Markus Deuling <deuling@de.ibm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
		  Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [rfc] [1/6] Remove macro CALL_DUMMY_LOCATION
Date: Wed, 30 May 2007 21:12:00 -0000	[thread overview]
Message-ID: <m3tztu583k.fsf@codesourcery.com> (raw)
In-Reply-To: <465BD442.4080300@de.ibm.com> (Markus Deuling's message of "Tue, 29 May 2007 09:20:34 +0200")


Markus Deuling <deuling@de.ibm.com> writes:
> this patch removes CALL_DUMMY_LOCATION macro from gdbarch.sh.
>
> ChangeLog:
>
> 	* gdbarch.sh (CALL_DUMMY_LOCATION): Replace by
> 	gdbarch_call_dummy_location.
> 	* infcall.c (call_function_by_hand): Likewise.
> 	* inferior.h: Change comment.
> 	* arch-utils.c: Change comment.
> 	* gdbarch.c, gdbarch.h: Regenerate.
>
>
> Is this ok to commit?

This looks good --- thank you!

But before you commit:

- Are your copyright papers in order?  I don't see your name appearing
  in the FSF's lists at all; Ulrich's does.

- It seems that others have been committing those patches of yours
  that have been approved so far; unless the answer to the first
  question bears on this somehow, you should have your own account on
  sourceware, and be added to the "Write After Approval" list.


  reply	other threads:[~2007-05-30 21:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-29  7:22 Markus Deuling
2007-05-30 21:12 ` Jim Blandy [this message]
2007-05-31 11:18   ` Markus Deuling
2007-05-31 17:24   ` Daniel Jacobowitz
2007-05-31 21:44     ` Jim Blandy
2007-06-01  1:00       ` Daniel Jacobowitz
2007-06-04 14:59         ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3tztu583k.fsf@codesourcery.com \
    --to=jimb@codesourcery.com \
    --cc=deuling@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox