From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-49101-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22987 invoked by alias); 30 May 2007 21:12:38 -0000
Received: (qmail 22976 invoked by uid 22791); 30 May 2007 21:12:38 -0000
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 30 May 2007 21:12:33 +0000
Received: (qmail 26538 invoked from network); 30 May 2007 21:12:31 -0000
Received: from unknown (HELO localhost) (jimb@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 30 May 2007 21:12:31 -0000
To: Markus Deuling <deuling@de.ibm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>, 	  Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [rfc] [1/6] Remove macro CALL_DUMMY_LOCATION
References: <465BD442.4080300@de.ibm.com>
From: Jim Blandy <jimb@codesourcery.com>
Date: Wed, 30 May 2007 21:12:00 -0000
In-Reply-To: <465BD442.4080300@de.ibm.com> (Markus Deuling's message of "Tue, 29 May 2007 09:20:34 +0200")
Message-ID: <m3tztu583k.fsf@codesourcery.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-05/txt/msg00424.txt.bz2


Markus Deuling <deuling@de.ibm.com> writes:
> this patch removes CALL_DUMMY_LOCATION macro from gdbarch.sh.
>
> ChangeLog:
>
> 	* gdbarch.sh (CALL_DUMMY_LOCATION): Replace by
> 	gdbarch_call_dummy_location.
> 	* infcall.c (call_function_by_hand): Likewise.
> 	* inferior.h: Change comment.
> 	* arch-utils.c: Change comment.
> 	* gdbarch.c, gdbarch.h: Regenerate.
>
>
> Is this ok to commit?

This looks good --- thank you!

But before you commit:

- Are your copyright papers in order?  I don't see your name appearing
  in the FSF's lists at all; Ulrich's does.

- It seems that others have been committing those patches of yours
  that have been approved so far; unless the answer to the first
  question bears on this somehow, you should have your own account on
  sourceware, and be added to the "Write After Approval" list.