From: Tom Tromey <tromey@redhat.com>
To: Stan Shebs <stan@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH/RFC] Include value of default-collect in breakpoint/tracepoint list
Date: Wed, 07 Apr 2010 19:56:00 -0000 [thread overview]
Message-ID: <m3tyrnujea.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4BBA7264.5060109@codesourcery.com> (Stan Shebs's message of "Mon, 05 Apr 2010 16:29:40 -0700")
>>>>> "Stan" == Stan Shebs <stan@codesourcery.com> writes:
Stan> 2010-04-05 Stan Shebs <stan@codesourcery.com>
Stan> * breakpoint.c (default_collect_info): New function.
Stan> (breakpoints_info): Call it.
Stan> (maintenance_info_breakpoints): Ditto.
Stan> (tracepoints_info): Ditto.
Stan> + static void default_collect_info (void);
Stan> + /* Display the value of default-collect in a way that is generally
Stan> + compatible with the breakpoint list. */
Stan> +
Stan> + void
Stan> + default_collect_info (void)
It is mildly weird for the declaration to have 'static' but not the
definition.
Also, I think the preferred style nowadays is to order functions so that
we don't need forward declarations (when possible).
FWIW, and since you asked, I think the idea behind the patch seems fine.
Tom
next prev parent reply other threads:[~2010-04-07 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-05 23:30 Stan Shebs
2010-04-07 19:56 ` Tom Tromey [this message]
2010-04-08 23:18 ` Stan Shebs
2010-04-09 0:55 ` Stan Shebs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3tyrnujea.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=stan@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox